[PVE-User] [PATCH container 1/1] Signed-off-by: Hugo Lecourt <hugo.lecourt at hugolecourt.fr>

[Hugo Lecourt]

I used git-send-mail
However, i'm not accustom to post in mailing list, so i fail this post
Will you, I re-post this in pve devel?
I have believe i'm not able to post in this list

Yes, the second fix is crappy

I've been test again, and there is no bug...
It's make no sense!

Sorry for waste of time...

Le mardi 26 mars 2019 à 09:01 +0100, Dominik Csapak a écrit :
> hi,
> 
> a few things to your patch:
> 
> * please use the developer list instead of the user list
> * please send the patch directly as mail (e.g. with git-send-email) 
> instead of as eml
> * use a meaningful subject
> 
> this information is all available in our developer-documentation[0]
> 
> to the patch itself:
> 
> what exactly is the bug?
> 
> i can not verify that all devices are added as usb3, but correctly as 
> usb2/usb1 (qm showcmd ID shows the qemu commandline that is generated)
> 
> the first hunk of yours does nothing, since at that point '$d' is not 
> used anymore, and the second hunk is wrong, since ehci bus cannot be 
> used with usb 1.x devices only usb 2.0
> 
> but even if your description was true (that all usb devices would be
> put on the xhci bus) this would still be ok, since the xhci controller
> can handle all usb 1.x,2.0, and 3.x devices
> 
> 0: https://pve.proxmox.com/wiki/Developer_Documentation
> 
> _______________________________________________
> pve-user mailing list
> pve-user at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-user
>