[pve-devel] [PATCH ha-manager 3/4] config, env: allow bulk updates with update_resources_config

Fiona Ebner f.ebner at proxmox.com
Mon Jan 19 13:44:44 CET 2026


Am 19.01.26 um 1:19 PM schrieb Daniel Kral:
> On Mon Jan 19, 2026 at 12:48 PM CET, Fiona Ebner wrote:
>> Nit: I feel like the $delete belongs inside the $changes for a clean
>> interface. So something like
>> $changes = {
>>   $sid => {
>>     param => $param,
>>     delete => $delete,
>>   }
>> }
>>
>> I know the single caller using bulk won't need it, but the current
>> interface does feel slightly off to me. What do you think?
> 
> Sounds good, will do! Just for clarification: Is `param => $param` a
> single changed property or is $param the hash of changes?

I'd keep them together as a hash. Then we don't mix keys for single
properties and the 'delete' key (which is on a different level
semantically).




More information about the pve-devel mailing list