[pve-devel] superseded: [PATCH container/docs/ha-manager/manager/proxmox-widget-toolkit/qemu-server v2 0/8] fix #6613: update HA rules upon resource deletion
Michael Köppl
m.koeppl at proxmox.com
Tue Sep 30 17:03:56 CEST 2025
Superseded-by:
https://lore.proxmox.com/pve-devel/20250930145848.263162-1-m.koeppl@proxmox.com/
On 9/24/25 6:07 PM, Michael Köppl wrote:
> This patch series aims to fix #6613 [0]. Although an implementation was
> proposed in the past, it was not applied since it was unclear how to
> handle the case where the removed resource is the last resource in a
> rule.
>
> The approach in this patch series is the following:
> - With the purge param activated (default), the
> resource is removed from any rule referencing it.
> - Without the purge param, rules are left untouched, making the removal
> of resources from rules "opt-out", as was suggested in the previous
> implementation [1].
> - If the resource was the last resource in the rule *and* the purge
> param is set, the rule will also be deleted.
> - For guest destruction, the "Purge from job configurations" option will
> also set the purge parameter for removing the HA resource
> - The purge param is set by default for resource removal in the GUI and
> CLI
>
> After some back-and-forth, I settled in this approach as the most
> intuitive and transparent. Alternative approaches considered were the
> following:
> - Updating rules even without the purge flag set, but failing and
> showing an error to the user if a rule would be deleted, prompting the
> user to enable the purge flag. This approach seems to be to
> restrictive and IMO doesn't add any UX value.
> - By default not setting the purge flag. This would by default leave
> "zombie" rules with non-existent resources. This is IMO intransparent
> if it happens by default. Users might be removing resources, not even
> knowing they're leaving behind rules that still reference said
> resources.
>
> But I'm also asking for input here if someone has a different opinion or
> suggestions for alternative approaches.
>
> Changes since v1:
> - Pulled read_rules_config and write_rules_config into conditional block
> in delete_service_from_config
> - Set `disabled: true` for the resource remove button, such that is can
> only be clicked if a resource was selected
> - Use ConfirmRemoveDialog as base for SafeDestroyResource to get a
> yes/no dialog with the additional checkbox instead of the SafeDestroy
> dialog that displays a warning and requires entering the ID of the
> resource again.
>
> Thanks to @Daniel for the review of v1!
>
> pve-ha-manager:
>
> Michael Köppl (2):
> fix #6613: update rules containing the resource to be deleted
> api: add purge parameter for resource deletion
>
> src/PVE/API2/HA/Resources.pm | 10 +++++++++-
> src/PVE/HA/Config.pm | 13 ++++++++++++-
> 2 files changed, 21 insertions(+), 2 deletions(-)
>
>
> qemu-server:
>
> Michael Köppl (1):
> fix #6613: pass purge param to delete_service_from_config
>
> src/PVE/API2/Qemu.pm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>
> pve-container:
>
> Michael Köppl (1):
> fix #6613: pass purge param to delete_service_from_config
>
> src/PVE/API2/LXC.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> proxmox-widget-toolkit:
>
> Michael Köppl (1):
> window: add ConfirmRemoveDialog
>
> src/Makefile | 1 +
> src/window/ConfirmRemoveDialog.js | 242 ++++++++++++++++++++++++++++++
> 2 files changed, 243 insertions(+)
> create mode 100644 src/window/ConfirmRemoveDialog.js
>
>
> pve-manager:
>
> Michael Köppl (2):
> ui: add SafeDestroyResource window
> ui: use SafeDestroyResource window for removing resources
>
> www/manager6/Makefile | 1 +
> www/manager6/ha/Resources.js | 16 ++++++---
> www/manager6/window/SafeDestroyResource.js | 41 ++++++++++++++++++++++
> 3 files changed, 54 insertions(+), 4 deletions(-)
> create mode 100644 www/manager6/window/SafeDestroyResource.js
>
>
> pve-docs:
>
> Michael Köppl (1):
> add notes about effects of purge flag for resource and guest removal
>
> ha-manager.adoc | 4 ++++
> pct.adoc | 3 +++
> qm.adoc | 3 +++
> 3 files changed, 10 insertions(+)
>
>
> Summary over all repositories:
> 12 files changed, 332 insertions(+), 8 deletions(-)
>
More information about the pve-devel
mailing list