[pve-devel] [PATCH pve-manager v2 1/4] api: add ACME plugin return schema
n.frey at proxmox.com
n.frey at proxmox.com
Wed Sep 24 13:59:01 CEST 2025
From: Nicolas Frey <n.frey at proxmox.com>
After looking at the code, I don't see any issues with using the
createSchema method. Additionally tested by comparing the output of:
- pvesh usage /cluster/acme/plugins --returns
- pvesh get /cluster/acme/plugins
confirmed that the contents match.
Signed-off-by: Nicolas Frey <n.frey at proxmox.com>
---
PVE/API2/ACMEPlugin.pm | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/PVE/API2/ACMEPlugin.pm b/PVE/API2/ACMEPlugin.pm
index 510101aa..d52bc90b 100644
--- a/PVE/API2/ACMEPlugin.pm
+++ b/PVE/API2/ACMEPlugin.pm
@@ -50,6 +50,8 @@ my $modify_cfg_for_api = sub {
return $plugin_cfg;
};
+my $acme_challenge_type = PVE::ACME::Challenge->createSchema();
+
__PACKAGE__->register_method({
name => 'index',
path => '',
@@ -72,12 +74,7 @@ __PACKAGE__->register_method({
},
returns => {
type => 'array',
- items => {
- type => "object",
- properties => {
- plugin => get_standard_option('pve-acme-pluginid'),
- },
- },
+ items => $acme_challenge_type,
links => [{ rel => 'child', href => "{plugin}" }],
},
code => sub {
@@ -111,9 +108,7 @@ __PACKAGE__->register_method({
id => get_standard_option('pve-acme-pluginid'),
},
},
- returns => {
- type => 'object',
- },
+ returns => $acme_challenge_type,
code => sub {
my ($param) = @_;
@@ -131,7 +126,7 @@ __PACKAGE__->register_method({
check => ['perm', '/', ['Sys.Modify']],
},
protected => 1,
- parameters => PVE::ACME::Challenge->createSchema(),
+ parameters => $acme_challenge_type,
returns => {
type => "null",
},
--
2.47.3
More information about the pve-devel
mailing list