[pve-devel] [PATCH proxmox_dart_api_client 1/2] fix: android: use `crone_http` package to honor user custom certificates
Michael Köppl
m.koeppl at proxmox.com
Wed Sep 3 12:16:30 CEST 2025
On Tue Sep 2, 2025 at 12:17 PM CEST, Shan Shaji wrote:
> In android when a user installs a custom certificate the app was not
> honoring the installed certificate and was still throwing
> `HandShakeException`.
>
> To fix the issue, used the `crone_http` [0] package which will honor the
nit: s/crone_http/cronet_http
Also: if I understand correctly based on quick search, the regular
dart:io HttpClient simply doesn't honor user-installed certificates at
all and there's no way to change that at the moment [0]? So adding this
dependency is necessary because it's one of the few ways (or maybe the
only way at the moment) to allow using user-installed certificates,
right? Just asking because I think it's always good to have some
rationale for additional dependencies. Might make sense to add this to
the commit message as well, I think.
[0] https://github.com/dart-lang/sdk/issues/50435
> user installed certificates. Used the standalone embedded library [1] of
> cronet inorder to avoid the dependency on Google Play Services.
>
> [0] - https://pub.dev/packages/cronet_http
> [1] - https://pub.dev/packages/cronet_http#use-embedded-cronet
>
> Signed-off-by: Shan Shaji <s.shaji at proxmox.com>
More information about the pve-devel
mailing list