[pve-devel] [PATCH manager v2 1/2] ui: set proxmoxRRDChart's unit at storage summary

[Shannon Sterz]

On Fri Aug 29, 2025 at 11:43 AM CEST, Maximiliano Sandoval wrote:
> This change ensures that the storage unites are displayed consistently
> between the graph and the usage label right above.
>
> When setting the unit to `bytes` the graph will now, for example, show
> "130 GB" instead of "130 G", which matches the usage displayed above and
> removes any ambiguity about whether "G" refers to GiB or GB.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval at proxmox.com>
> ---
>
> Differences from v1:
>
>  - Use lowercase in commit name
>  - Add a second commit changing the renderer of the bytes_used
>
>
>  www/manager6/storage/Summary.js | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/www/manager6/storage/Summary.js b/www/manager6/storage/Summary.js
> index 8809603b..b263cb87 100644
> --- a/www/manager6/storage/Summary.js
> +++ b/www/manager6/storage/Summary.js
> @@ -52,6 +52,7 @@ Ext.define('PVE.storage.Summary', {
>                      fields: ['total', 'used'],
>                      fieldTitles: ['Total Size', 'Used Size'],
>                      store: rrdstore,
> +                    unit: 'bytes',
>                  },
>              ],
>              listeners: {


looks good to me, consider this:

Tested-by: Shannon Sterz <s.sterz at proxmox.com>
Reviewed-by: Shannon Sterz <s.sterz at proxmox.com>