[pve-devel] [PATCH manager v8 3/4] fix #1926 ui: vm console: autodetect novnc or xtermjs

[Michael Köppl]

On Fri Oct 3, 2025 at 5:00 PM CEST, Aaron Lauterer wrote:
> @@ -474,7 +477,7 @@ Ext.define('PVE.qemu.Config', {
>                  lock = rec ? rec.data.value : undefined;
>  
>                  spice = !!s.data.get('spice');
> -                xtermjs = !!s.data.get('serial');
> +                xtermjs = PVE.Utils.isSerialDisplay(s.data.get('display')?.data.value.type);
>              }
>  
>              rec = s.data.get('tags');
> @@ -486,6 +489,10 @@ Ext.define('PVE.qemu.Config', {
>  
>              var resume = ['prelaunch', 'paused', 'suspended'].indexOf(qmpstatus) !== -1;
>  
> +            me.lookup('submenuConsoleBtn')?.loadConsole(xtermjs, 'kvm');
> +
> +            statusTxt.update({ lock: lock });
> +

Might be that I'm just missing something, but why was this moved up
compared to v7? I don't think this is related to the rebase?

>              if (resume || lock === 'suspended') {
>                  startBtn.setVisible(false);
>                  resumeBtn.setVisible(true);