[pve-devel] [PATCH SERIES docs/ha-manager/manager v2] close #6144: add ui button + api for node maintenance mode
Daniel Kral
d.kral at proxmox.com
Thu Oct 2 13:53:19 CEST 2025
On Sat Sep 20, 2025 at 8:20 PM CEST, Thomas Skinner wrote:
> Continued work on node maintenance mode button in UI.
>
> Changes since V1:
> - Code refactoring/reformatting
> - Clarity in docs
> - Remove redundant GET API for maintenance status
> - Change button UI to dropdown menu with icons
Sorry for the wait on a review for this..
Thanks for the v2, works as expected and apart from the inline note
about the permission it looks good to me.
I think it was be better to have a single Enable/Disable toggle button
instead of a dropdown if there's no current development to add more
maintenance modes to HA LRMs, but I don't want to be nitpicky about
this, so with the permission note resolved consider this as:
Reviewed-by: Daniel Kral <d.kral at proxmox.com>
Tested-by: Daniel Kral <d.kral at proxmox.com>
More information about the pve-devel
mailing list