[pve-devel] [PATCH common 3/3] upid: fix calls to decode function

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Oct 1 12:34:54 CEST 2025


Am 01.10.25 um 11:38 schrieb Fiona Ebner:
> The decode function has a signature and always requires two arguments.
> Otherwise, there will be errors like:
>> Too few arguments for subroutine 'PVE::UPID::decode'
>> (got 1; expected 2) at /usr/share/perl5/PVE/UPID.pm line 60.

I replaced this with just adapting the signature to have a default
value for $noerr defined there, which avoids having to update
call sides; as thanks to use v5.36 we can do

sub decode($upid, $noerr = 0) {
    ...


I also added a basic test harness to finally have some coverage
here.




More information about the pve-devel mailing list