[pve-devel] [PATCH proxmox-ve-rs v2 1/1] config: guest: store network devices in BTreeMap
Hannes Laimer
h.laimer at proxmox.com
Wed Oct 1 09:23:13 CEST 2025
On 9/25/25 14:22, Stefan Hanreich wrote:
> Enables iterating over the network devices in order, without
> performing any additional sorting at the call sites. This makes the
> output in proxmox-firewall stable, which is useful for test cases as
> well as for comparing the output of different proxmox-firewall runs.
>
Are we actually explicitly sorting anywhere? I didn't really find any
places. If there should be, we can drop those. Nonetheless this makes a
lot if sense.
> Signed-off-by: Stefan Hanreich <s.hanreich at proxmox.com>
> ---
> proxmox-ve-config/src/guest/vm.rs | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/proxmox-ve-config/src/guest/vm.rs b/proxmox-ve-config/src/guest/vm.rs
> index cc97781..baff1b8 100644
> --- a/proxmox-ve-config/src/guest/vm.rs
> +++ b/proxmox-ve-config/src/guest/vm.rs
> @@ -1,4 +1,4 @@
> -use std::collections::HashMap;
> +use std::collections::BTreeMap;
> use std::io;
> use std::str::FromStr;
>
> @@ -278,7 +278,7 @@ impl FromStr for NetworkDevice {
> #[derive(Debug, Default)]
> #[cfg_attr(test, derive(Eq, PartialEq))]
> pub struct NetworkConfig {
> - network_devices: HashMap<i64, NetworkDevice>,
> + network_devices: BTreeMap<i64, NetworkDevice>,
> }
>
> impl NetworkConfig {
> @@ -300,12 +300,12 @@ impl NetworkConfig {
> bail!("No index found in net key string: {key}")
> }
>
> - pub fn network_devices(&self) -> &HashMap<i64, NetworkDevice> {
> + pub fn network_devices(&self) -> &BTreeMap<i64, NetworkDevice> {
> &self.network_devices
> }
>
> pub fn parse<R: io::BufRead>(input: R) -> Result<Self, Error> {
> - let mut network_devices = HashMap::new();
> + let mut network_devices = BTreeMap::new();
>
> for line in input.lines() {
> let line = line?;
More information about the pve-devel
mailing list