[pve-devel] [PATCH v6 pve-container 0/5] warn that nesting may be required

[Robert Obkircher]

This patch adds a task-log warning on CT start if systemd is detected.

Changes since v5:
- improved comment
- (attempted to rewrite path concatenation but ended up leaving it
  unchanged)

Changes since v4:
- removed unnecessary eval
- chomp log message
- remove vmid argument when calling log_warn

Changes since v3:
- split and reordered the first 3 commits
- constrain and untaint the objdump path
- also warn in post_clone and post_create 

Changes since v2:
- read $@ before new eval to preserve error
- remove trailing whitespace

Changes since v1:
- increase minimum systemd version to something more reasonable
- introduce helper callback to log warinings
    - replace RESTEnvironmnet::log_warn in setup plugins
- syntactic changes:
    - renamed get_may_require_nesting_warning to check_systemd_nesting
    - use trailing if for return statements
    - call code from pre_start_hook as suggested


Robert Obkircher (5):
  Ensure that container startup warnings are displayed if startup fails.
  Propagate prestart-hook warnings to task-log.
  fix #6897: warn that nesting may be required for systemd
  fix #6897: constrain and untaint path for systemd version detection
  fix #6897: also warn in the post_clone and post_create hooks

 src/PVE/LXC.pm              |  6 +++---
 src/PVE/LXC/Setup.pm        | 21 ++++++++++++++++++---
 src/PVE/LXC/Setup/Base.pm   | 30 ++++++++++++++++++++++++++++--
 src/PVE/LXC/Setup/Debian.pm |  5 ++---
 src/PVE/LXC/Setup/Plugin.pm |  2 +-
 src/PVE/LXC/Setup/Ubuntu.pm |  5 ++---
 src/lxc-pve-prestart-hook   | 27 +++++++++++++--------------
 7 files changed, 67 insertions(+), 29 deletions(-)

-- 
2.47.3