[pve-devel] superseded: [PATCH apiclient/common/manager v3 0/5] implement cluster-wide bulk-actions for guests

Dominik Csapak d.csapak at proxmox.com
Fri Nov 14 16:00:33 CET 2025


superseded by v4 (i missed somethings for tokens)
https://lore.proxmox.com/pve-devel/20251114145927.3766668-1-d.csapak@proxmox.com/

On 11/14/25 3:42 PM, Dominik Csapak wrote:
> This is a continuation of my previous patch[0]. It includes some changes on
> how we handle tokens/tickets as well as the gui is now using this too, which
> highlighted some choices in the api that i now changed (see the changelog
> for details)
> 
> changes from v2 (thanks @fabian for most of these):
> * handle tokens by exposing credentials via rpcenv
> * reauthenticate the client when the ticket are more than 1 hour old
> * use log_warn instead of 'warn' and 'print STDERR' where sensible
>    (some places are now simply a 'print')
> * moved 'statestorage' check into the condition for 'to-disk'
> * removed one 'statestorage' permission check completely since now
>    the target api can handle this check properly
> * adding some retrying logic for querying the task status
> * rename some api parameters to be more aligned with the gui
> 
> changes from v1:
> * rebased on master (perltidy changes)
> * added missing suspend to index
> * refactored more functionality to be reused
> 
> 0: https://lore.proxmox.com/pve-devel/20250814112659.2584520-1-d.csapak@proxmox.com/
> 
> pve-apiclient:
> 
> Dominik Csapak (1):
>    try to refresh ticket before an api call
> 
>   src/PVE/APIClient/LWP.pm | 21 ++++++++++++++++++++-
>   1 file changed, 20 insertions(+), 1 deletion(-)
> 
> 
> pve-common:
> 
> Dominik Csapak (1):
>    json schema/rest environment: add 'expose_credentials' option
> 
>   src/PVE/JSONSchema.pm      |  8 ++++++++
>   src/PVE/RESTEnvironment.pm | 14 ++++++++++++++
>   2 files changed, 22 insertions(+)
> 
> 
> pve-manager:
> 
> Dominik Csapak (3):
>    http server/pvesh: set credentials if necessary
>    api: implement node-independent bulk actions
>    ui: add bulk actions to the datacenter level
> 
>   PVE/API2/Cluster.pm                  |   7 +
>   PVE/API2/Cluster/BulkAction.pm       |  45 ++
>   PVE/API2/Cluster/BulkAction/Guest.pm | 770 +++++++++++++++++++++++++++
>   PVE/API2/Cluster/BulkAction/Makefile |  17 +
>   PVE/API2/Cluster/Makefile            |   4 +-
>   PVE/API2/Nodes.pm                    |  24 +-
>   PVE/CLI/pvesh.pm                     |  18 +
>   PVE/HTTPServer.pm                    |   5 +
>   www/manager6/dc/Config.js            |  68 +++
>   www/manager6/window/BulkAction.js    |  50 +-
>   10 files changed, 987 insertions(+), 21 deletions(-)
>   create mode 100644 PVE/API2/Cluster/BulkAction.pm
>   create mode 100644 PVE/API2/Cluster/BulkAction/Guest.pm
>   create mode 100644 PVE/API2/Cluster/BulkAction/Makefile
> 
> 
> Summary over all repositories:
>    13 files changed, 1029 insertions(+), 22 deletions(-)
> 





More information about the pve-devel mailing list