[pve-devel] [PATCH ha-manager v3 05/21] rules: add merged positive resource affinity info in global checks

[Daniel Kral]

On Mon Nov 3, 2025 at 6:24 PM CET, Michael Köppl wrote:
> On Mon Nov 3, 2025 at 11:19 AM CET, Daniel Kral wrote:
>> The node affinity and positive resource affinity rule subsets are
>> checked whether HA resources in a positive resource affinity rule are in
>> more than one node affinity rule in total, and if so prunes them as
>> those are not feasible [0].
>
> nit: The link is missing

Thanks for taking a look!

Oops, I wanted to add some notes in [0] why these are not feasible here,
but instead added another patch adding some documentation which is
hopefully more likely to be read than some patch message, but forgot to
remove the [0] here.

I'll wait if there's more feedback for this series, but if there isn't
then I hope this can be fixed when applying to reduce noise ;).

>
>>
>> This check has the assumption that each positive resource affinity
>> rule's resource set is disjoint from each other, but this is only done
>> in the later transformation stage when positive resource affinity with
>> overlapping HA resources in them are merged to one rule.
>>
>> For example, the following inconsistent rules are not pruned:
>>
>> - positive resource affinity rule between vm:101 and vm:102
>> - positive resource affinity rule between vm:102 and vm:103
>> - node affinity rule for vm:101 on node1
>> - node affinity rule for vm:103 on node3
>>
>> Therefore build the same disjoint positive resource affinity resource
>> sets as the merge_connected_positive_resource_affinity_rules(...)
>> subroutine, so that the inconsistency check has the necessary
>> information in advance.
>>
>> Fixes: c48d9e66 ("rules: restrict inter-plugin resource references to simple cases")
>> Signed-off-by: Daniel Kral <d.kral at proxmox.com>