[pve-devel] [PATCH-SERIES storage 0/4] lvm plugin: error handling and locking fixes

[Friedrich Weber]

On 03/11/2025 17:23, Fiona Ebner wrote:
> Patch 1/4 is improving an error message by including the previously
> captured error.
> 
> Patch 2/4 fixes error handling in volume_snapshot_rollback().
> Previously, allocation would be ignored when 'saferemove' was enabled
> on the storage.
> 
> Patches 3/4 and 4/4 fix the locking for volume import and snapshot
> operations. Better viewed with "-w" or
> "-w --word-diff=color --word-diff-regex='\w+'".

Thanks for the patch!

I tested the series in my 2-node cluster with shared iSCSI + LVM +
Snapshot-as-volume-chain. My previous reproducer for the metadata
corruption (creating and deleting snapshots of two VMs on the two nodes
in a loop) does not trigger a metadata corruption anymore, so:

Tested-by: Friedrich Weber <f.weber at proxmox.com>

Note I have not tested the parallel import scenario sketched in patch 3/4.