[pve-devel] [PATCH-SERIES storage 0/4] lvm plugin: error handling and locking fixes

[Fiona Ebner]

Patch 1/4 is improving an error message by including the previously
captured error.

Patch 2/4 fixes error handling in volume_snapshot_rollback().
Previously, allocation would be ignored when 'saferemove' was enabled
on the storage.

Patches 3/4 and 4/4 fix the locking for volume import and snapshot
operations. Better viewed with "-w" or
"-w --word-diff=color --word-diff-regex='\w+'".

I noticed that the default timeout of 10 seconds for locking
essentially means only having 10 tries to acquire the lock [0], which
in a busy cluster might not be enough to get the lock with high
confidence. This is not fully orthogonal to the series here, since we
might want to either change that [0] or to use a higher timeout for
(some of) the callers here.

[0]: https://git.proxmox.com/?p=pve-cluster.git;a=blob;f=src/PVE/Cluster.pm;h=e829687a74224408106f74ee6873a44095f0ff4f;hb=HEAD#l601

pve-storage:

Fiona Ebner (4):
  lvm plugin: snapshot delete: propagate previously captured error
  lvm plugin: fix error handling in volume_snapshot_rollback()
  lvm plugin: volume import: lock allocation and removal sections
  lvm plugin: snapshot-as-volume-chain: use locking for snapshot
    operations

 src/PVE/Storage/LVMPlugin.pm | 128 ++++++++++++++++++++++++++---------
 1 file changed, 96 insertions(+), 32 deletions(-)


Summary over all repositories:
  1 files changed, 96 insertions(+), 32 deletions(-)

-- 
Generated by git-murpp 0.5.0