[pve-devel] [PATCH proxmox-widget-toolkit v3 1/1] network selector: add type parameter

Stefan Hanreich s.hanreich at proxmox.com
Thu May 22 18:17:11 CEST 2025


The network endpoint of the PVE API allows selecting interfaces by
type, but the network selector widget currently does not support
passing the type to the API call.

This is required for the SDN fabrics, which introduced a new special
type to this endpoint that additionally selects all SDN interfaces.
This can then be used to make SDN fabrics show up in the Migration
Settings dialog or in the Ceph Installation Wizards.

Signed-off-by: Stefan Hanreich <s.hanreich at proxmox.com>
---
 src/form/NetworkSelector.js | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/src/form/NetworkSelector.js b/src/form/NetworkSelector.js
index caa7b7e..8fa3d60 100644
--- a/src/form/NetworkSelector.js
+++ b/src/form/NetworkSelector.js
@@ -8,7 +8,10 @@ Ext.define('Proxmox.form.NetworkSelectorController', {
 	if (!view.nodename) {
 	    throw "missing custom view config: nodename";
 	}
-	view.getStore().getProxy().setUrl('/api2/json/nodes/'+ view.nodename + '/network');
+	view
+	    .getStore()
+	    .getProxy()
+	    .setUrl(`/api2/json/nodes/${view.nodename}/network${view.getQueryString()}`);
     },
 });
 
@@ -33,6 +36,11 @@ Ext.define('Proxmox.form.NetworkSelector', {
 
     controller: 'proxmoxNetworkSelectorController',
 
+    type: undefined,
+    getQueryString: function() {
+	return this.type ? `?type=${this.type}` : '';
+    },
+
     nodename: 'localhost',
     setNodename: function(nodename) {
 	this.nodename = nodename;
@@ -41,7 +49,9 @@ Ext.define('Proxmox.form.NetworkSelector', {
 	// because of manual local copy of data for ip4/6
 	this.getPicker().refresh();
 	if (networkSelectorStore && typeof networkSelectorStore.getProxy === 'function') {
-	    networkSelectorStore.getProxy().setUrl('/api2/json/nodes/'+ nodename + '/network');
+	    networkSelectorStore
+		.getProxy()
+		.setUrl(`/api2/json/nodes/${nodename}/network${this.getQueryString()}`);
 	    networkSelectorStore.load();
 	}
     },
-- 
2.39.5




More information about the pve-devel mailing list