[pve-devel] [PATCH pve_flutter_frontend] chore: assets: update flutter app icons in iOS with proxmox icons

Shan Shaji s.shaji at proxmox.com
Thu May 22 11:33:00 CEST 2025


Thank you so much for the review. The changes in the `Contents.json` was
done by Xcode when i dragged and dropped the icons into the asset
catalog of Xcode. I will create another patch by removing all the
formatting and reordering changes from the `Contents.json` file. 

On Wed May 21, 2025 at 1:27 PM CEST, Dominik Csapak wrote:
> while i can't test the changes for ios, the images look good,
> one question for my curiosity:
>
> what triggered the changes in the Contents.json ?
>
> AFAICS it's just reordering the properties + whitespace changes, which
> make it hard to see if there was any actual change to the content...
>
> not that I'm against it, but we should probably not unnecessarily touch these files,
> except some tooling (e.g. from flutter) autoformats these or there
> are real changes...
























































































































































































































































More information about the pve-devel mailing list