[pve-devel] [PATCH proxmox_login_manager] refactor: rename `MaterialState` to `WidgetState`

Shan Shaji s.shaji at proxmox.com
Thu May 22 09:32:06 CEST 2025


Thank you so much for the review. I will seperate this into multiple
patches. 


On Wed May 21, 2025 at 1:12 PM CEST, Dominik Csapak wrote:
> not a super big issue, but 2 hunks seem to be unrelated to the commit message
> (see inline)
>
> it would be much nicer to have the commits clean, so I'd appreciate it when you send
> a v2 that either
> * has separate patches for the different things (i would much prefer that)
> * change the commit message to include what is fixed/improved

> _______________________________________________
> pve-devel mailing list
> pve-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel





More information about the pve-devel mailing list