[pve-devel] [PATCH container v5 2/4] lxc: get volid through parse_volume()
Thomas Lamprecht
t.lamprecht at proxmox.com
Mon May 19 10:09:35 CEST 2025
Am 19.05.25 um 09:50 schrieb Michael Köppl:
> Thanks for the hint! It seems I have missed that option, wasn't sure how
> to handle it otherwise. Will use it in the future. If a v6 of this
> series becomes necessary, I'll add Stefan's former email address again.
Please send a v6 in any case with the trailers being complete even if
nothing else comes up over a day or so. That way it's easier to avoid that
something bogus will be pushed out. We currently have no automation to
check these things, and they can be somewhat easy to overlook. And it's
always great if one can avoid that maintainers need to do extra work on
applying/pushing things, as often their plate is rather full as is already.
And FWIW, automation here wouldn't even be that hard to add using gitolite
hooks, but it doesn't come up often, so nobody see any benefit in doing so.
Albeit it can make sense to start a general check for S-o-b existing and
maybe some other simple low false-positive checks and then adding an
"incomplete trailer" check would be rather cheap.
More information about the pve-devel
mailing list