[pve-devel] [PATCH pve-storage 3/5] lvmplugin: add qcow2 snapshot

[DERUMIER, Alexandre]

the overhead and LV size messages I patched in for debugging purposes..

>>something with the overhead calculation must be wrong? if I make the
>>overhead twice as much, it works..

It's work for me if the vm if offline, I think this is the problem with
the size defined in bytes or kb, depend of the code path if the vm is
offline or online. (I don't remember exactly where, I need to check)


LV size: 33558528
qcow2: size=34359738368

> +    push @$tags, "\@pve-$name" if $fmt eq 'qcow2';
> +    lvcreate($vg, $name, $lvmsize, $tags);
> +
> +    #format the lvm volume with qcow2 format

>>and also I just realized that I missed this in my first pass - we
>>should return here
>>if the format is not qcow2, instead of making the lvm_qcow2_format a
>>nop in that case..

ah yes, sorry, I'll fix it