[pve-devel] [PATCH pve-storage 4/5] storage: vdisk_free: remove external snapshots

[Fabian Grünbichler]

On May 10, 2025 2:28 pm, DERUMIER, Alexandre wrote:
> 
> 
>> Alexandre Derumier via pve-devel <pve-devel at lists.proxmox.com> hat am
>> 22.04.2025 13:51 CEST geschrieben:
>> add a $include_snapshots param to free_image to
>> remove the whole chain of snapshots when deleting the main image.
> 
>>>rbd, zfs, btrfs, lvmthin and qcow2 internal snapshots already all
>>>behave like this by default..
>>>
>>>shouldn't we just implement this for external snapshots without the
>>>need to opt into
>>it?
> 
> it was mostly because I'm using free_image to delete specific current
> snapshot images in the plugin snapshot_delete.
> Maybe with I can invert the option, like  $skip_snapshots ?
> what do you think ?

no, you just need to factor out an internal helper instead of polluting
the free_image interface/API..