[pve-devel] applied: [PATCH storage] iscsi direct plugin: add trailing newline to error messages

Fiona Ebner f.ebner at proxmox.com
Fri May 9 13:42:17 CEST 2025


Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
---
 src/PVE/Storage/ISCSIDirectPlugin.pm | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/PVE/Storage/ISCSIDirectPlugin.pm b/src/PVE/Storage/ISCSIDirectPlugin.pm
index 829e0c4..d54dcd8 100644
--- a/src/PVE/Storage/ISCSIDirectPlugin.pm
+++ b/src/PVE/Storage/ISCSIDirectPlugin.pm
@@ -92,7 +92,7 @@ sub parse_volname {
 sub path {
     my ($class, $scfg, $volname, $storeid, $snapname) = @_;
 
-    die "volume snapshot is not possible on iscsi device"
+    die "volume snapshot is not possible on iscsi device\n"
 	if defined($snapname);
 
     my ($vtype, $lun, $vmid) = $class->parse_volname($volname);
@@ -182,7 +182,7 @@ sub deactivate_storage {
 sub activate_volume {
     my ($class, $storeid, $scfg, $volname, $snapname, $cache) = @_;
 
-    die "volume snapshot is not possible on iscsi device" if $snapname;
+    die "volume snapshot is not possible on iscsi device\n" if $snapname;
 
     return 1;
 }
@@ -190,7 +190,7 @@ sub activate_volume {
 sub deactivate_volume {
     my ($class, $storeid, $scfg, $volname, $snapname, $cache) = @_;
 
-    die "volume snapshot is not possible on iscsi device" if $snapname;
+    die "volume snapshot is not possible on iscsi device\n" if $snapname;
 
     return 1;
 }
@@ -206,22 +206,22 @@ sub volume_size_info {
 
 sub volume_resize {
     my ($class, $scfg, $storeid, $volname, $size, $running) = @_;
-    die "volume resize is not possible on iscsi device";
+    die "volume resize is not possible on iscsi device\n";
 }
 
 sub volume_snapshot {
     my ($class, $scfg, $storeid, $volname, $snap) = @_;
-    die "volume snapshot is not possible on iscsi device";
+    die "volume snapshot is not possible on iscsi device\n";
 }
 
 sub volume_snapshot_rollback {
     my ($class, $scfg, $storeid, $volname, $snap) = @_;
-    die "volume snapshot rollback is not possible on iscsi device";
+    die "volume snapshot rollback is not possible on iscsi device\n";
 }
 
 sub volume_snapshot_delete {
     my ($class, $scfg, $storeid, $volname, $snap) = @_;
-    die "volume snapshot delete is not possible on iscsi device";
+    die "volume snapshot delete is not possible on iscsi device\n";
 }
 
 sub volume_has_feature {
-- 
2.39.5





More information about the pve-devel mailing list