[pve-devel] applied: [PATCH qemu-server] drive: code cleanup: remove unused $vmid argument from get_iso_path() helper

Fiona Ebner f.ebner at proxmox.com
Tue May 6 14:56:31 CEST 2025


According to git history, the $vmid argument was never used.

Reported-by: Alexandre Derumier <alexandre.derumier at groupe-cyllene.com>
Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
---
 PVE/QemuServer/Drive.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/PVE/QemuServer/Drive.pm b/PVE/QemuServer/Drive.pm
index 81e1aa04..473970c1 100644
--- a/PVE/QemuServer/Drive.pm
+++ b/PVE/QemuServer/Drive.pm
@@ -87,7 +87,7 @@ sub get_cdrom_path {
 }
 
 sub get_iso_path {
-    my ($storecfg, $vmid, $cdrom) = @_;
+    my ($storecfg, $cdrom) = @_;
 
     if ($cdrom eq 'cdrom') {
 	return get_cdrom_path();
@@ -112,7 +112,7 @@ sub get_path_and_format {
     my ($storeid) = PVE::Storage::parse_volume_id($volid, 1);
 
     if (drive_is_cdrom($drive)) {
-	$path = get_iso_path($storecfg, $vmid, $volid);
+	$path = get_iso_path($storecfg, $volid);
 	die "$drive_id: cannot back cdrom drive with a live restore image\n" if $live_restore_name;
     } else {
 	if ($storeid) {
-- 
2.39.5





More information about the pve-devel mailing list