[pve-devel] [PATCH proxmox-widget-toolkit 3/3] notification: smtp: don't split translatable string

[Maximiliano Sandoval]

Lukas Wagner <l.wagner at proxmox.com> writes:

> Splitting a string can make it harder or even impossible to provide an
> accurate translation.
>
> Signed-off-by: Lukas Wagner <l.wagner at proxmox.com>
> ---
>  src/panel/SmtpEditPanel.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/panel/SmtpEditPanel.js b/src/panel/SmtpEditPanel.js
> index a7cfaff..37e4d51 100644
> --- a/src/panel/SmtpEditPanel.js
> +++ b/src/panel/SmtpEditPanel.js
> @@ -76,7 +76,7 @@ Ext.define('Proxmox.panel.SmtpEditPanel', {
>              fieldLabel: gettext('Encryption'),
>              editable: false,
>              comboItems: [
> -                ['insecure', Proxmox.Utils.noneText + ' (' + gettext('insecure') + ')'],
> +                ['insecure', gettext('None (insecure)')],
>                  ['starttls', 'STARTTLS'],
>                  ['tls', 'TLS'],
>              ],


lgtm.

Reviewed-by: Maximiliano Sandoval <m.sandoval at proxmox.com>