[pve-devel] [RFC container] setup: remove deprecated dsa from ssh host key generation

[Daniel Kral]

On 6/27/25 10:46, Fabian Grünbichler wrote:
> we already have PVE::LXC::Setup::rewrite_ssh_host_keys which AFAICT is
> called unconditionally in Setup::post_create_hook even for unmanaged
> containers, given that precedent I think we can just extend that..

Oh wait, just was reminded that rewrite_ssh_host_keys is unconditionally 
called in Setup::post_create_hook, but ssh_host_key_types_to_generate is 
overwritten in Setup::Unmanaged to return empty, i.e. do not rewrite any 
ssh host keys.

Should we still extend it here or keep it in 
Setup::Base::post_create_hook(...)? Else I send a tested patch with 
those changes afterwards :)