[pve-devel] [PATCH qemu-server 19/31] drive: die in get_drive_id() if argument misses relevant members

Fiona Ebner f.ebner at proxmox.com
Wed Jun 25 17:56:42 CEST 2025


Catch errors early instead of continuing with unexpected values.

Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
---
 src/PVE/QemuServer/Drive.pm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/PVE/QemuServer/Drive.pm b/src/PVE/QemuServer/Drive.pm
index a6b8c72c..a6f5062f 100644
--- a/src/PVE/QemuServer/Drive.pm
+++ b/src/PVE/QemuServer/Drive.pm
@@ -841,6 +841,10 @@ sub print_drive {
 
 sub get_drive_id {
     my ($drive) = @_;
+
+    die "get_drive_id: no interface" if !defined($drive->{interface});
+    die "get_drive_id: no index" if !defined($drive->{index});
+
     return "$drive->{interface}$drive->{index}";
 }
 
-- 
2.47.2





More information about the pve-devel mailing list