[pve-devel] applied: [PATCH installer v2 1/2] assistant: validate: warn if answer file contains old snake_case keys
Thomas Lamprecht
t.lamprecht at proxmox.com
Tue Jun 24 16:54:05 CEST 2025
Am 24.06.25 um 13:40 schrieb Christoph Heiss:
> Parses the TOML file as a `Value` without structure and then just
> iterates over all keys. An exception is made for filter values, as these
> contain raw udev key names.
>
> Signed-off-by: Christoph Heiss <c.heiss at proxmox.com>
> ---
> v1: https://lore.proxmox.com/pve-devel/20250430112628.723073-1-c.heiss@proxmox.com/
> Changes v1 -> v2:
> * rebased on latest master
>
> Implements a more robust version of
> https://lore.proxmox.com/pve-devel/20250217121748.117222-6-d.kral@proxmox.com/
> by actually parsing the TOML and iterating over the keys.
>
> proxmox-auto-install-assistant/src/main.rs | 71 +++++++++++++++++--
> proxmox-auto-installer/src/answer.rs | 4 +-
> proxmox-auto-installer/src/utils.rs | 12 ++--
> .../tests/resources/parse_answer/btrfs.toml | 4 +-
> .../btrfs_raid_level_uppercase.toml | 4 +-
> .../resources/parse_answer/disk_match.toml | 6 +-
> .../parse_answer/disk_match_all.toml | 6 +-
> .../parse_answer/disk_match_any.toml | 6 +-
> .../resources/parse_answer/first_boot.toml | 4 +-
> .../parse_answer/fqdn_from_dhcp.toml | 4 +-
> ...cp_no_dhcp_domain_with_default_domain.toml | 4 +-
> ...ll_fqdn_from_dhcp_with_default_domain.toml | 4 +-
> .../parse_answer/hashed_root_password.toml | 4 +-
> .../tests/resources/parse_answer/minimal.toml | 4 +-
> .../resources/parse_answer/nic_matching.toml | 4 +-
> .../resources/parse_answer/specific_nic.toml | 5 +-
> .../tests/resources/parse_answer/zfs.toml | 6 +-
> .../zfs_raid_level_uppercase.toml | 6 +-
> .../both_password_and_hashed_set.json | 2 +-
> .../both_password_and_hashed_set.toml | 6 +-
> .../fqdn_from_dhcp_no_default_domain.toml | 4 +-
> .../parse_answer_fail/fqdn_hostname_only.toml | 4 +-
> .../parse_answer_fail/no_fqdn_from_dhcp.toml | 4 +-
> .../no_root_password_set.json | 2 +-
> .../no_root_password_set.toml | 2 +-
> .../parse_answer_fail/short_password.json | 2 +-
> .../parse_answer_fail/short_password.toml | 4 +-
> 27 files changed, 123 insertions(+), 65 deletions(-)
>
>
applied this one for now, waiting on your input on my reply of the second
patch, thanks!
More information about the pve-devel
mailing list