[pve-devel] superseded: [PATCH manager 1/2] ui: remove handling of obsolete notification-policy/target settings

Lukas Wagner l.wagner at proxmox.com
Tue Jun 24 13:30:19 CEST 2025


Superseded-by:
https://lore.proxmox.com/all/20250624112817.132312-1-l.wagner@proxmox.com/T/#t

On  2025-06-12 11:55, Lukas Wagner wrote:
> These were only used in the 'old' revamped notification stack which was
> briefly available on pvetest. With PVE 9 we can finally get completely
> rid of these.
> 
> Signed-off-by: Lukas Wagner <l.wagner at proxmox.com>
> ---
> Only intended for PVE 9.
> 
>  www/manager6/dc/Backup.js | 16 ----------------
>  1 file changed, 16 deletions(-)
> 
> diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
> index 381402ca..688befe7 100644
> --- a/www/manager6/dc/Backup.js
> +++ b/www/manager6/dc/Backup.js
> @@ -37,14 +37,6 @@ Ext.define('PVE.dc.BackupEdit', {
>  		delete values.node;
>  	    }
>  
> -	    // Get rid of new-old parameters for notification settings.
> -	    // These should only be set for those selected few who ran
> -	    // pve-manager from pvetest.
> -	    if (!isCreate) {
> -		Proxmox.Utils.assemble_field_data(values, { 'delete': 'notification-policy' });
> -		Proxmox.Utils.assemble_field_data(values, { 'delete': 'notification-target' });
> -	    }
> -
>  	    let selMode = values.selMode;
>  	    delete values.selMode;
>  
> @@ -158,14 +150,6 @@ Ext.define('PVE.dc.BackupEdit', {
>  	    let me = this;
>  	    let viewModel = me.getViewModel();
>  
> -	    // Migrate 'new'-old notification-policy back to old-old mailnotification.
> -	    // Only should affect users who used pve-manager from pvetest. This was a remnant of
> -	    // notifications before the  overhaul.
> -	    let policy = data['notification-policy'];
> -	    if (policy === 'always' || policy === 'failure') {
> -		data.mailnotification = policy;
> -	    }
> -
>  	    if (data.exclude) {
>  		data.vmid = data.exclude;
>  		data.selMode = 'exclude';

-- 
- Lukas





More information about the pve-devel mailing list