[pve-devel] [PATCH cluster v2 3/3] datacenter config: introduce feature flag for location rules
Thomas Lamprecht
t.lamprecht at proxmox.com
Tue Jun 24 10:25:13 CEST 2025
Am 24.06.25 um 10:19 schrieb Daniel Kral:
> On 6/24/25 09:51, Thomas Lamprecht wrote:
>> That said, might not really require a named ID's here anyway, having
>> a list (array) of rules and a short 127 or 255 max-length free-form
>> comment might be more helpful here anyway, as that avoids the need
>> to choose an available ID while still allowing to encode hints and
>> rationale for certain rule entries.
>
> Right, especially because ids can't be changed but comments can, I'll
> also prefer that much over forcing users to come up with new names for
> rules and not being able to change them (without the delete/create
> cycle). I guess something similar to the user.cfg layout would do it?
FWIW, we could keep ID's for simplicity but auto-generate them on
creation (probably frontend side though to not break the POST-only-once
REST-API principle.) and not show them in the UI by default.
Similar to what we did at a few places in PBS, albeit there we allowed
overriding it as there references to those IDs can exist, for affinity
rules that probably should not matter, at least nothing would come to
my mind that would need referencing them.
Biggest advantage is that we can keep section config format here and
avoid a semi-custom format. The user.cfg is inspired by shadow.cfg,
which does a similar job so it's more relatable there (and it's one of
the older config files), so I'd not take it too much as example.
More information about the pve-devel
mailing list