[pve-devel] [PATCH qemu-server v2 08/32] drive: remove geometry options gone since QEMU 3.1

[Fiona Ebner]

Am 20.06.25 um 13:03 schrieb Fabian Grünbichler:
> On June 18, 2025 3:01 pm, Fiona Ebner wrote:
>> It was not possible to start a QEMU instance with these options set
>> since QEMU version 3.1, QEMU commit b24ec3c462 ("block: Remove
>> deprecated -drive geometry options") and thus also not to take a
>> backup. It is still possible to restore an old backup with these
>> options set.
> 
> we could do this unconditionally on parsing a drive line, it doesn't
> really matter whether the context is regular parsing or restore parsing,
> it's better to just drop the offending properties rather than the whole
> drive in both cases.

I didn't want to make it accidentally possible to still write e.g. qm
set 123 --scsi0 dir:1,cyls=3 after this. But actually, this is caught
already earlier even if parse_drive() would support it. And yes, not
being quite like you suggested in the other reply will help too!

> while it is not very likely such old configs are still around, it would
> also allow us to drop the previous two patches and keep the interface
> simpler..

Ack.