[pve-devel] [PATCH manager v2] fix #4166: restore: add resource pool selector
Thomas Lamprecht
t.lamprecht at proxmox.com
Tue Jun 17 17:45:15 CEST 2025
Am 12.06.25 um 10:23 schrieb Maximiliano Sandoval:
> The pool selector is only visible when restoring from the
> Datacenter->{node}->{storage}->Backups panel.
I mean fine for now, but IMO if the user has enough rights then restoring
to another pool for when overwriting an existing VM might make sense to;
but that can definitively be an independent change.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval at proxmox.com>
> ---
>
> Differences from v1:
> - Hide the pool selector when restoring a VM in-place.
>
> www/manager6/window/Restore.js | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/www/manager6/window/Restore.js b/www/manager6/window/Restore.js
> index 22900868..6f9c9f2f 100644
> --- a/www/manager6/window/Restore.js
> +++ b/www/manager6/window/Restore.js
> @@ -47,6 +47,9 @@ Ext.define('PVE.window.Restore', {
> if (values.storage) {
> params.storage = values.storage;
> }
> + if (values.pool) {
> + params.pool = values.pool;
> + }
>
> ['bwlimit', 'cores', 'name', 'memory', 'sockets'].forEach(opt => {
> if ((values[opt] ?? '') !== '') {
> @@ -186,6 +189,14 @@ Ext.define('PVE.window.Restore', {
> fieldLabel: gettext('Source'),
> },
> storagesel,
> + {
> + xtype: 'pvePoolSelector',
> + fieldLabel: gettext('Resource Pool'),
> + name: 'pool',
> + value: '',
> + allowBlank: true,
> + hidden: me.vmid,
> + },
Should this better get placed in the override section?
> {
> xtype: 'pmxDisplayEditField',
> name: 'vmid',
More information about the pve-devel
mailing list