[pve-devel] [PATCH qemu-server 13/22] vm start: move config_to_command() call further down

[Fiona Ebner]

Am 13.06.25 um 12:05 schrieb Fabian Grünbichler:
> On June 12, 2025 4:02 pm, Fiona Ebner wrote:
>> @@ -5654,16 +5642,28 @@ sub vm_start_nolock {
>>  	($state_cmdline, $res->{migrate}, $statefile_is_a_volume) =
>>  	    PVE::QemuServer::StateFile::statefile_cmdline_option(
>>  		$storecfg, $vmid, $statefile, $migrate_opts, $migration_ip);
>> -	push @$vollist, $statefile if $statefile_is_a_volume;
>>      } elsif ($params->{paused}) {
>>  	$state_cmdline = ['-S'];
>>      }
>>  
>> -    push $cmd->@*, $state_cmdline->@*;
>> -
>>      my $memory = get_current_memory($conf->{memory});
>>      my $start_timeout = $params->{timeout} // config_aware_timeout($conf, $memory, $resume);
> 
> this part here now operates on the original instead of the minimized
> config in case of a template/.. - shouldn't be a problem, but wanted to
> call it out in case you disagree since it wasn't mentioned..

Good catch! I'll keep these two lines below. We should keep using the
timeout for the effectively used config.