[pve-devel] [PATCH qemu-server v3 2/6] fix #4225: qemuserver: introduce sub eject_nonrequired_isos

Daniel Herzig d.herzig at proxmox.com
Fri Jan 31 14:58:54 CET 2025


Fiona Ebner <f.ebner at proxmox.com> writes:

> Am 31.01.25 um 10:36 schrieb Fiona Ebner:
>> Am 30.01.25 um 12:31 schrieb Daniel Herzig:
>>> +
>>> +    $drive->{essential} = 1 if !defined($drive->{essential});
>> 
>> This should rather be done when parsing the drive.
>
> Or I guess to avoid (potentially) writing it out for every drive, it
> should only be a local variable here and not set in the drive hash.

Thanks, I'll double check on this for v4. But I'd assume the hash to be scoped to
`config_to_command` here, or am I missing something?





More information about the pve-devel mailing list