[pve-devel] [PATCH qemu-server v3 0/6] bugzilla #4225 -- improve handling of unavailable ISOs

[Daniel Herzig]

This patch series addresses bugzilla entry #4225.

Currently VMs refuse to to start if a configured isofile becomes unavailable,
be it a deleted file or an unavailable network storage.

This patch series introduces a new parameter in Drive.pm, called 'essential'.
Depending on whether this parameter is set or not, the situation will be handled
differently.

If the parameter is set to 0, the configuration will temporarily changed to use
'none' as file for the cd drive, which allows qemu to start up the machine.
The configuration is not changed in this process to avoid unexpected behaviour.
Instead a log_warn will be issued.

For transition reasons an unset parameter acts like 'required=1'. In this case
the startup process will die earlier than currently, if the file is missing or
the underlying storage not available.

If a new VM is created from the WebGUI, a corresponding added checkbox
is checked by default, but allows for convenient unchecking during setup time,
eg for media that is only needed for installation time.

This patch series adds an 'Eject' button to the hardwareview in the WebGUI,
which can be used as a convenience shortcut to setting file to 'none' for the
cdrom drive.

This series supersedes:
https://lore.proxmox.com/pve-devel/20250113085608.99498-1-d.herzig@proxmox.com/

Changes since v2:
* rebased onto current masters (qemu-server: 0fc03fc1, pve-manager: bbba1c53)
* refactored patch series structure (THX @Dano)
* shortened code and streamlined code logic (qemu-server, THX @Dano)
* reduced changes on testing framework (qemu-server)
* reuse existing code for parsing values (pve-manager, THX @Friedrich)
* properly html-encode warning messages (pve-manager, THX @Friedrich)


qemu-server: Daniel Herzig (3):
  fix #4225: qemuserver: drive: add parameter to mark drive required
  fix #4225: qemuserver: introduce sub eject_nonrequired_isos
  fix #4225: qemuserver, test: put eject_nonrequired_isos in place

 PVE/QemuServer.pm                             | 37 ++++++++++++++++++
 PVE/QemuServer/Drive.pm                       |  9 ++++-
 test/cfg2cmd/ide-required-iso-missing.conf    | 12 ++++++
 .../cfg2cmd/ide-required-iso-missing.conf.cmd |  0
 .../cfg2cmd/ide-required-iso-offline-nfs.conf | 12 ++++++
 .../ide-required-iso-offline-nfs.conf.cmd     |  0
 test/cfg2cmd/ide-required.conf                | 14 +++++++
 test/cfg2cmd/ide-required.conf.cmd            | 39 +++++++++++++++++++
 test/cfg2cmd/ide-unrequired-iso-missing.conf  | 12 ++++++
 .../ide-unrequired-iso-missing.conf.cmd       | 33 ++++++++++++++++
 .../ide-unrequired-iso-offline-nfs.conf       | 12 ++++++
 .../ide-unrequired-iso-offline-nfs.conf.cmd   | 33 ++++++++++++++++
 test/run_config2command_tests.pl              | 36 +++++++++++++++++
 13 files changed, 248 insertions(+), 1 deletion(-)
 create mode 100644 test/cfg2cmd/ide-required-iso-missing.conf
 create mode 100644 test/cfg2cmd/ide-required-iso-missing.conf.cmd
 create mode 100644 test/cfg2cmd/ide-required-iso-offline-nfs.conf
 create mode 100644 test/cfg2cmd/ide-required-iso-offline-nfs.conf.cmd
 create mode 100644 test/cfg2cmd/ide-required.conf
 create mode 100644 test/cfg2cmd/ide-required.conf.cmd
 create mode 100644 test/cfg2cmd/ide-unrequired-iso-missing.conf
 create mode 100644 test/cfg2cmd/ide-unrequired-iso-missing.conf.cmd
 create mode 100644 test/cfg2cmd/ide-unrequired-iso-offline-nfs.conf
 create mode 100644 test/cfg2cmd/ide-unrequired-iso-offline-nfs.conf.cmd

pve-manager: Daniel Herzig (3):
  fix #4225: ui: form: isoselector: add checkbox for 'essential' param
  fix #4225: ui: qemu: cdedit: enable 'Essential' checkbox for isos
  fix #4225: ui: qemu: hardware: add eject button for cdroms

 www/manager6/form/IsoSelector.js  | 22 ++++++++++++++++
 www/manager6/qemu/CDEdit.js       |  8 ++++++
 www/manager6/qemu/HardwareView.js | 42 +++++++++++++++++++++++++++++++
 3 files changed, 72 insertions(+)

-- 
2.39.5