[pve-devel] [PATCH manager] pvestatd: improve broadcast of node version-info

[Aaron Lauterer]

Until now, the pvestatd did broadcast the pve-manager version only once
after startup of the service. But there are some situations, where the
local pmxcfs (pve-cluster) restarts and loses that information.
Basically everytime we restart the pmxcfs without restarting pvestatd
too.

For example, on a cluster join, or if the pmxcfs has been restarted
manually.

By additionally checking if the local kv-store of the pmxcfs has any
version info for the node, we can decide if another broadcast is
necessary.
Therefore after the next run of pvestatd, we should have the full
version info available again.

Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
---
This patch is preparation to get reliable version infos as I am picking
of the patch series of Folke to include more metrics into the RRD data
and summary graphs. [0]
This was a big blocker and now with the major version change coming up,
we at least can assume the latest 8.x installed as part of the update to
PVE 9.
Therefore, we should get this in with PVE 8. Additional patches for PVE
8 will follow to make the transition smoother. But as mentioned, this
here is one of the things that needs to work reliably, which is why I
submit the patch already now.

[0] https://lore.proxmox.com/pve-devel/20231211144721.212071-1-f.gleumes@proxmox.com/

 PVE/Service/pvestatd.pm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/PVE/Service/pvestatd.pm b/PVE/Service/pvestatd.pm
index 7fa003fe..03c578e1 100755
--- a/PVE/Service/pvestatd.pm
+++ b/PVE/Service/pvestatd.pm
@@ -527,7 +527,10 @@ sub update_sdn_status {
 
 my $broadcast_version_info_done = 0;
 my sub broadcast_version_info : prototype() {
-    if (!$broadcast_version_info_done) {
+    if (
+	!$broadcast_version_info_done
+	|| !keys PVE::Cluster::get_node_kv('version-info', $nodename)->%*
+    ) {
 	PVE::Cluster::broadcast_node_kv(
 	    'version-info',
 	    encode_json(PVE::pvecfg::version_info()),
-- 
2.39.5