[pve-devel] [PATCH v2 11/12] fix #4225: ui: qemu: cdedit: enable required checkbox for isos

Daniel Kral d.kral at proxmox.com
Thu Jan 16 16:19:22 CET 2025


On 1/13/25 09:56, Daniel Herzig wrote:
> Enables the 'required' checkbox for the IsoSelector.
> If the parameter is not set, the backend will use the default (set to
> 1).
> 
> Behaviour:
> * Only send parameter if not default (required=0)
> * Checked if parameter is missing (default)
> * Unchecked when adding a new CD-ROM

IMO the part of this patch where new VMs get created with `required=0` 
CDROMs should be split into its own patch and marked as "for-9.0" or 
else add a TODO comment for the 9.0 release.

Else this looks good, so consider this:

Reviewed-by: Daniel Kral <d.kral at proxmox.com>
Tested-by: Daniel Kral <d.kral at proxmox.com>




More information about the pve-devel mailing list