[pve-devel] [PATCH v3 qemu-server 09/11] blockdev: mirror: change aio on target if io_uring is not default.

[DERUMIER, Alexandre]

> +    #change aio if io_uring is not supported on target
> +    if ($dst_drive->{aio} && $dst_drive->{aio} eq 'io_uring') {
> + my ($dst_storeid) = PVE::Storage::parse_volume_id($dst_drive-
> >{file});
> + my $dst_scfg = PVE::Storage::storage_config($storecfg,
> $dst_storeid);
> + my $cache_direct = drive_uses_cache_direct($dst_drive, $dst_scfg);
> + if(!storage_allows_io_uring_default($dst_scfg, $cache_direct)) {
> +     $dst_drive->{aio} = $cache_direct ? 'native' : 'threads';
> + }
> +    }

>>couldn't/shouldn't we just handle this in generate_file_blockdev?

yes, better to reuse existing code to avoid difference. I'll do it.