[pve-devel] [PATCH v3 pve-common 00/12] Introduce and Package PVE::Path & PVE::Filesystem

Max Carrara m.carrara at proxmox.com
Thu Jan 9 15:48:06 CET 2025


Introduce and Package PVE::Path & PVE::Filesystem - v3
======================================================

Notable Changes Since v2
------------------------

- Mention that `path_components` will contain a '/' component at the
  beginning of the returned list if the passed path is absolute
- Note behaviour regarding absolute paths being passed to `path_join` in
  its docstring and refer to `path_push`
- Add a little extra info regarding parent path references and symlinks
  in docstring of `path_parent`
- Don't return reference to list in scalar context anymore

Many thanks to Wolfgang for the great review and feedback! [1]

References
----------

[1]: https://lore.proxmox.com/pve-devel/s7he5i3khrtkja3ozl34tgoue7m4xnrvqhydnhcg67xp54zrgw@dnd37ovkjfqt/

Older Versions
--------------

v1: https://lore.proxmox.com/pve-devel/20241219183143.526267-1-m.carrara@proxmox.com/
v2: https://lore.proxmox.com/pve-devel/20241220185207.519912-1-m.carrara@proxmox.com/

Summary of Changes
------------------

Max Carrara (12):
  introduce PVE::Path
  test: add directory for tests of PVE::Path module
  test: add tests for path_is_absolute and path_is_relative of PVE::Path
  test: add tests for path_components of PVE::Path
  test: add tests for path_join of PVE::Path
  test: add tests for path_push of PVE::Path
  test: add tests for path_parent of PVE::Path
  test: add tests for path_starts_with, path_ends_with, path_equals
  test: add test for file path operation functions of PVE::Path
  test: add tests for path_normalize of PVE::Path
  introduce PVE::Filesystem
  debian: introduce package libproxmox-fs-path-utils-perl

 debian/control                               |    6 +
 debian/libproxmox-fs-path-utils-perl.install |    2 +
 debian/libpve-common-perl.install            |   29 +
 src/Makefile                                 |    2 +
 src/PVE/Filesystem.pm                        |   78 ++
 src/PVE/Path.pm                              |  991 ++++++++++++++
 test/Makefile                                |    5 +-
 test/Path/Makefile                           |   24 +
 test/Path/path_comparison_tests.pl           |  851 ++++++++++++
 test/Path/path_components_tests.pl           |  162 +++
 test/Path/path_file_ops_tests.pl             | 1226 ++++++++++++++++++
 test/Path/path_is_absolute_relative_tests.pl |  122 ++
 test/Path/path_join_tests.pl                 |  310 +++++
 test/Path/path_normalize_tests.pl            |  176 +++
 test/Path/path_parent_tests.pl               |  153 +++
 test/Path/path_push_tests.pl                 |  159 +++
 16 files changed, 4295 insertions(+), 1 deletion(-)
 create mode 100644 debian/libproxmox-fs-path-utils-perl.install
 create mode 100644 debian/libpve-common-perl.install
 create mode 100644 src/PVE/Filesystem.pm
 create mode 100644 src/PVE/Path.pm
 create mode 100644 test/Path/Makefile
 create mode 100755 test/Path/path_comparison_tests.pl
 create mode 100755 test/Path/path_components_tests.pl
 create mode 100755 test/Path/path_file_ops_tests.pl
 create mode 100755 test/Path/path_is_absolute_relative_tests.pl
 create mode 100755 test/Path/path_join_tests.pl
 create mode 100755 test/Path/path_normalize_tests.pl
 create mode 100755 test/Path/path_parent_tests.pl
 create mode 100755 test/Path/path_push_tests.pl

-- 
2.39.5





More information about the pve-devel mailing list