[pve-devel] [PATCH pve_flutter_frontend] Updated Gradle version and some build dependencies.

[Shannon Sterz]

On Thu Feb 20, 2025 at 3:37 PM CET, Alexander Abraham wrote:
> The Flutter frontend of PVE was not compilable for Android
> with the versions of different tools set in the project files.
> The versions of the tools causing this problem was updated
> and the app compiles for Android.
>
> Signed-off-by: Alexander Abraham <a.abraham at proxmox.com>
> ---
>  android/app/build.gradle                         | 10 +++++++++-
>  android/gradle/wrapper/gradle-wrapper.properties |  2 +-
>  android/settings.gradle                          |  4 ++--
>  3 files changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/android/app/build.gradle b/android/app/build.gradle
> index 4f827a5..59c318d 100644
> --- a/android/app/build.gradle
> +++ b/android/app/build.gradle
> @@ -45,6 +45,7 @@ def keystoreSecret = System.getenv('PROXMOX_APP_KEYSTORE_SECRET')
>
>  android {
>      compileSdkVersion 34
> +    namespace = "com.proxmox.app.pve_flutter_frontend"

i haven't tested this, don't have a flutter setup here, but the
inconsistent use of "=" seems strange to me. looking at the android
documentation you are supposed to use either "=" consistently in a
build.gradle.kts file or not in a build.gradle file.

did you mix them intentionally?

[1]: https://developer.android.com/build/gradle-build-overview#kts

>
>      sourceSets {
>          main.java.srcDirs += 'src/main/kotlin'
> @@ -52,7 +53,7 @@ android {
>
>
>      defaultConfig {
> -        applicationId "com.proxmox.app.pve_flutter_frontend"
> +        applicationId namespace
>          minSdkVersion 23
>          targetSdkVersion 34
>          versionCode flutterVersionCode.toInteger()
> @@ -74,9 +75,16 @@ android {
>              signingConfig signingConfigs.release
>          }
>      }
> +    compileOptions {
> +        sourceCompatibility JavaVersion.VERSION_17
> +        targetCompatibility JavaVersion.VERSION_17
> +    }
>      lint {
>          disable 'InvalidPackage'
>      }
> +    kotlinOptions{
> +        jvmTarget = '17'
> +    }
>  }
>
>  flutter {
> diff --git a/android/gradle/wrapper/gradle-wrapper.properties b/android/gradle/wrapper/gradle-wrapper.properties
> index 0732d12..90d1364 100644
> --- a/android/gradle/wrapper/gradle-wrapper.properties
> +++ b/android/gradle/wrapper/gradle-wrapper.properties
> @@ -1,6 +1,6 @@
>  #Mon Apr 24 14:18:06 CEST 2023
>  distributionBase=GRADLE_USER_HOME
>  distributionPath=wrapper/dists
> -distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-bin.zip
> +distributionUrl=https\://services.gradle.org/distributions/gradle-8.10.2-all.zip
>  zipStoreBase=GRADLE_USER_HOME
>  zipStorePath=wrapper/dists
> diff --git a/android/settings.gradle b/android/settings.gradle
> index 4fc86fd..1da49ad 100644
> --- a/android/settings.gradle
> +++ b/android/settings.gradle
> @@ -18,8 +18,8 @@ pluginManagement {
>
>  plugins {
>      id "dev.flutter.flutter-plugin-loader" version "1.0.0"
> -    id "com.android.application" version "7.4.2" apply false
> -    id "org.jetbrains.kotlin.android" version "1.7.20" apply false
> +    id "com.android.application" version "8.7.0" apply false
> +    id "org.jetbrains.kotlin.android" version "1.8.22" apply false
>  }
>
>  include ':app'