[pve-devel] [PATCH qemu-server v2 08/15] tree-wide: update vdisk_alloc optional arguments signature
Fiona Ebner
f.ebner at proxmox.com
Thu Feb 20 15:36:57 CET 2025
Am 11.02.25 um 17:08 schrieb Daniel Kral:
> @@ -552,9 +554,9 @@ my sub create_disks : prototype($$$$$$$$$$$) {
> } elsif ($ds eq 'tpmstate0') {
> # swtpm can only use raw volumes, and uses a fixed size
> $size = PVE::Tools::convert_size(PVE::QemuServer::Drive::TPMSTATE_DISK_SIZE, 'b' => 'kb');
> - $volid = PVE::Storage::vdisk_alloc($storecfg, $storeid, $vmid, "raw", undef, $size);
> + $volid = PVE::Storage::vdisk_alloc($storecfg, $storeid, $vmid, 'raw', $size);
Nit: AFAIK, we don't have a clear policy when using 'string' vs "string"
so would be better to avoid mixing in that as an unrelated change.
More information about the pve-devel
mailing list