[pve-devel] [PATCH qemu-server v2 06/15] fix #5284: api: update-vm: assert content type support for cloudinit images

[Fiona Ebner]

Am 11.02.25 um 17:08 schrieb Daniel Kral:
> Asserts whether the target storage supports storing cloudinit images,
> i.e. VM images, before creating a cloudinit image on the target storage.
> 
> Without the check in place, a cloudinit image can be created on the
> storage, which does not support VM images, but won't be able to start
> since any attached volume must be stored on a supported storage.
> 
> Signed-off-by: Daniel Kral <d.kral at proxmox.com>
> ---
> changes since v1:
> - new bug fix! (was indirectly fixed in rfc at commit_cloudinit_image)
> 
>  PVE/API2/Qemu.pm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
> index 2a2d971e..9fadf3e5 100644
> --- a/PVE/API2/Qemu.pm
> +++ b/PVE/API2/Qemu.pm
> @@ -142,12 +142,13 @@ my $check_storage_access = sub {
>  
>  	my $volid = $drive->{file};
>  	my ($storeid, $volname) = PVE::Storage::parse_volume_id($volid, 1);
> +	my $is_cloudinit = defined($volname) && $volname eq 'cloudinit';
>  
> -	if (!$volid || ($volid eq 'none' || (defined($volname) && $volname eq 'cloudinit'))) {
> +	if (!$volid || $volid eq 'none') {
>  	    # nothing to check
>  	} elsif ($isCDROM && ($volid eq 'cdrom')) {
>  	    $rpcenv->check($authuser, "/", ['Sys.Console']);
> -	} elsif (!$isCDROM && ($volid =~ $PVE::QemuServer::Drive::NEW_DISK_RE)) {
> +	} elsif (!$isCDROM && ($volid =~ $PVE::QemuServer::Drive::NEW_DISK_RE || $is_cloudinit)) {

A cloudinit drive should be a CD-ROM. Can we even reach here?

>  	    $rpcenv->check($authuser, "/storage/$storeid", ['Datastore.AllocateSpace']);
>  	    my $scfg = PVE::Storage::storage_config($storecfg, $storeid);
>  	    raise_param_exc({ storage => "storage '$storeid' does not support vm images"})