[pve-devel] [PATCH manager v5 2/5] bulk migrate: improve precondition checks

[Christoph Heiss]

On Mon Jan 20, 2025 at 3:51 PM CET, Dominik Csapak wrote:
[..]
> diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
> index 9cdf19db..6fe7a5fd 100644
> --- a/PVE/API2/Nodes.pm
> +++ b/PVE/API2/Nodes.pm
> @@ -2331,11 +2331,23 @@ my $create_migrate_worker = sub {
>  	    $invalidConditions .= join(', ', map { $_->{volid} } @{$preconditions->{local_disks}});
>  	}
>  
> -	if (@{$preconditions->{local_resources}}) {
> +	if ($online && scalar($preconditions->{local_resources}->@*)) {
>  	    $invalidConditions .= "\n  Has local resources: ";
>  	    $invalidConditions .= join(', ', @{$preconditions->{local_resources}});
>  	}
>  
> +	if (my $not_allowed_nodes = $preconditions->{not_allowed_nodes}) {
> +	    if (my $unavail_storages = $not_allowed_nodes->{$target}->{unavailable_storages}) {
> +		$invalidConditions .= "\n  Has unavailable storages: ";
> +		$invalidConditions .= join(', ', $unavail_storages->@*);
> +	    }
> +
> +	    if (my $unavail_resources = $not_allowed_nodes->{$target}->{'unavailable-resources'}) {
> +		$invalidConditions .= "\n  Has unavailable resources ";

Nit: Above both messages have colons before the item names, so add it
here too?

> +		$invalidConditions .= join(', ', $unavail_resources->@*);
> +	    }
> +	}
> +