[pve-devel] applied: [PATCH container 2/2] migration: add reminder to evaluate dropping seemingly useless check for PVE 9

[Thomas Lamprecht]

Am 11.02.25 um 10:45 schrieb Fiona Ebner:
> Am 10.02.25 um 17:12 schrieb Thomas Lamprecht:
>> Am 18.12.24 um 11:32 schrieb Fiona Ebner:
>>> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
>>> ---
>>>  src/PVE/LXC/Migrate.pm | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>>
>>
>> applied, thanks!
>>
>> The first patch was already applied by Fabian on 2024-12-19:
>>
>> https://git.proxmox.com/?p=pve-container.git;a=commit;h=a257aa44969e0775f8b31ff729f7ad591bd304b9
> 
> Fabian told me (off-list, well...) that it's still useful as an early

ah great, neither an applied mail nor a mail with such an outcome stated...

> check and that makes sense. I guess it can be improved by querying the
> transport formats for all disks early via the storage layer proper, but
> the check should not be dropped completely. And IIRC, VM migration is
> currently missing such an early check.

Still thanks for the info, I now pushed a revert of this patch with some
context in the commit message.