[pve-devel] [PATCH qemu-server 4/4] migration: remove wrong attempt of disabling 'rdma-pin-all' capability
Fiona Ebner
f.ebner at proxmox.com
Fri Feb 7 15:18:21 CET 2025
This was added by a89fded1 ("migration : enable auto-converge
capability v2"), but migration capabilities are already disabled by
default and there is nothing special about 'rdma-pin-all' compared to
other ones that are not used by Proxmox VE. Morover, the code
currently doesn't even do anything, because the capability would need
to be set as 'rdma-pin-all' without the experimental 'x-' marker
prefix (at least since QEMU 8.0, maybe longer).
The function to set migration capabilities already queries which ones
are supported by the currently running QEMU and ignores others, so
there was no error about the invalid name.
Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
---
PVE/QemuServer.pm | 1 -
1 file changed, 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 7731bda9..30d8c238 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -4635,7 +4635,6 @@ sub set_migration_caps {
my $enabled_cap = {
"auto-converge" => 1,
"xbzrle" => 1,
- "x-rdma-pin-all" => 0,
"dirty-bitmaps" => $dirty_bitmaps,
};
--
2.39.5
More information about the pve-devel
mailing list