[pve-devel] [RFC v1 pve-storage 0/6] RFC: Tighter API Control for Storage Plugins

[Fiona Ebner]

Am 05.02.25 um 16:20 schrieb Max Carrara:
> On Wed Feb 5, 2025 at 12:17 PM CET, Wolfgang Bumiller wrote:
>> I don't think accidentally-public private helpers should be considered
>> part of the API. We can just deprecate them immediately, remove them
>> "soon". They aren't part of the `PVE::Storage`<->`Plugin` surface after
>> all.
> 
> Hmm, fair. I wasn't sure what our stance on that exactly is, so I
> dediced to be conservative here; as in: "If it's being used by someone
> else, then it's already part of an API", if that makes sense.
> 
> Though, since we're fine with removing them, I'll just migrate them soon
> and provide wrappers that emit a warning (or something) in case any
> third-party modules are still using them. Once we do a major / minor
> bump of PVE, we can remove the wrappers while not touching the storage
> API{VER,AGE} (at least not for those helpers specifically).

I'd also err on the side of caution here. We never explicitly documented
what is and isn't part of the plugin API, so chances are that some
external plugins do make use of some such helpers. Removing them during
a minor release or without APIAGE reset will not be nice to plugin
authors. We'll likely do an APIAGE reset for PVE 9 in any case, so we
could just do the breaking change for such helpers then too.