[pve-devel] [PATCH qemu-server] qmp helpers: device add: use HMP interface

[Fiona Ebner]

Am 04.02.25 um 16:24 schrieb Fiona Ebner:
> The timeout of 60 seconds is used, because that is the same that's
> currently used by the 'drive_add' HMP commands and a too low timeout
> is known to cause issues [0]. While 'drive_del' uses 10 minutes, there
> were no issues reported with the 'device_del' operations using the
> default timeout until now, but it still makes sense to increase,
> because for some devices IO might need to happen during detach, so use
> 60 seconds for now too.

Actually, I'm a bit torn with the 60 seconds. We really didn't have many
reports of issues here and this might feel like too long from a user
perspective. Increasing in specific cases can always still be done, but
device-plug is often done interactively, so might be bad UX to have too
much. The bug report [0] mentions that 7 seconds is enough for the
operation, so maybe using 30 seconds as the timeout is better?