[pve-devel] [PATCH storage 05/11] lvm plugin: snapshot delete: clarify comment about using commit

Fiona Ebner f.ebner at proxmox.com
Tue Dec 16 14:02:16 CET 2025


The volume size of the child might actually be bigger if there was a
resize. However, in terms of actual data that needs to be merged, the
child is usually smaller.

Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
---
 src/PVE/Storage/LVMPlugin.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm
index a134334..0200666 100644
--- a/src/PVE/Storage/LVMPlugin.pm
+++ b/src/PVE/Storage/LVMPlugin.pm
@@ -1201,7 +1201,8 @@ sub volume_snapshot_delete {
     my $childvolname = $snapshots->{$childsnap}->{volname};
 
     my $err = undef;
-    #if first snapshot,as it should be bigger,  we merge child, and rename the snapshot to child
+    # if first snapshot, as it should be bigger in terms of actual data, we merge child, and rename
+    # the snapshot to child
     if (!$parentsnap) {
         print "$volname: deleting snapshot '$snap' by commiting snapshot '$childsnap'\n";
         print "running 'qemu-img commit $childpath'\n";
-- 
2.47.3





More information about the pve-devel mailing list