[pve-devel] applied: [pbs-devel] [PATCH pve-xtermjs] Avoid allocating in `pre_exec` closure
Thomas Lamprecht
t.lamprecht at proxmox.com
Tue Dec 9 17:25:27 CET 2025
On Fri, 05 Dec 2025 12:47:50 +0000, Yuki Sireneva wrote:
> `Error::new` allocates memory (see [148971]). This is bad in
> multi-threaded programs, which pve-xtermjs AFAIK is. If the fork occurs
> while the allocator lock is held by another thread, deadlocks can occur,
> since there's no one left in the new process to unlock the mutex.
> I do not believe this is UB, and modern libc offer protections against
> this issue, but this isn't POSIX-compliant and should preferably be
> avoided.
>
> [...]
Applied, thanks!
[1/1] Avoid allocating in `pre_exec` closure
commit: 41051f5a5e7bce513a6e0e31cacea44cab988391
More information about the pve-devel
mailing list