[pve-devel] [PATCH pve-storage v1 0/3] Improve mkpath Error Message in activate_storage

[Max R. Carrara]

Noticed a thread in the forum[forum] today where a user ran into the
following error when configuring a new NFS storage:

"create storage failed: mkdir /path/to/mountpoint/: Permission denied at
/usr/share/perl5/PVE/Storage/Plugin.pm line 1919"

Since it seemed that the user couldn't really interpret the error
correctly, improve that particular part in the code and make the error
handling / messaging a bit nicer for end users there.

Patch 01 and 02 just adapt the surrounding code in preparation; patch 03
contains the improvement as well as additional details.

References
----------

[forum]: https://forum.proxmox.com/threads/bug-creating-nfs-volume-storage.177354/

Summary of Changes
------------------

Max R. Carrara (3):
  plugin: use guard clause to reduce nesting
  plugin: remove needless inequality check when creating content subdirs
  plugin: improve error handling when creating a content subdir fails

 src/PVE/Storage/Plugin.pm | 75 +++++++++++++++++++++++++--------------
 1 file changed, 49 insertions(+), 26 deletions(-)

-- 
2.47.3