[pve-devel] [PATCH ha-manager 18/18] factor out counting of active services into helper

[Daniel Kral]

On Fri Aug 29, 2025 at 2:44 PM CEST, Michael Köppl wrote:
> During my review I was wondering why 16/18 and 17/18 added similar
> checks to both the manager's and the API's active service counting and
> why they're not combined into a single helper function, only to then
> notice that the final patch does exactly that. Is there a reason it's
> done in this order? Other patches in this series do it the other way
> around or combine the introduction of a new helper function and its use.

It could probably be squashed together in a single commit, but I added
the intermediate changes as individual patches because they actually
change the behavior there and only afterwards factor it out when all
behave the same way. The other patches factor it out before and then use
that helper/etc without any change in behavior.

It was more a matter of taste so that if these behavioral changes turn
out to be a cause of a bug, it's easier to bisect than having quite a
large change in one, but no hard feelings to change that in a v2.